Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #458 Fix sending emails on local env and replace Mailcatcher image #476

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

mkleszcz
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Fixes #458

Fixes sending emails on local environment and replaces Mailcatcher instance built from Dockerfile with image from Docker Hub

What is the current behavior?

Mailcatcher build will fail on new SB installations.

What is the new behavior?

It will load publicly available image from docker hub

Does this PR introduce a breaking change?

No

…cher instance built from Dockerfile with image from Docker Hub
…cher instance built from Dockerfile with image from Docker Hub
@mkleszcz mkleszcz merged commit dc6a710 into master Feb 13, 2024
53 checks passed
@mkleszcz mkleszcz deleted the fix/local-sending-mails branch February 13, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mailcatcher/Dockerfile build is failing on initial attempt
2 participants