Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #358 Move docker-create-volumes.sh script to project.json #367

Closed
wants to merge 1 commit into from

Conversation

mkleszcz
Copy link
Contributor

@mkleszcz mkleszcz commented Aug 2, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Remove the bash script that breaks local environment on Windows machines

What is the current behavior?

App won't start locally on Windows

Fixes #358

@mkleszcz
Copy link
Contributor Author

mkleszcz commented Aug 3, 2023

Unfortunately this won't work on Windows because of the invalid name interpolation... I was trying to solve the issue using cross-env-shell and it works but then there was another issue with the second script docker-login.sh which is called before build:(
I gave up because there was no simple solution to this and simply use the WSL 2 to set this up on Windows.

@mkleszcz mkleszcz closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make up command not working on Windows
1 participant