-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: widget icon in Connect To options in oneclick binding menu #36703
base: release
Are you sure you want to change the base?
Conversation
…o fix/list-ocb-widget-icon
…o fix/list-ocb-widget-icon
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Description
This pull request fixes the issue with the widget icon not displaying correctly in the Connect To options.
The
useConnectToOptions
function now correctly retrieves the widget config for the current widget and uses theiconSVG
property from the config to display the widget icon.Fixes #
Issue Number
or
Fixes #36353
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Sanity, @tag.Widget"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11180735006
Commit: 80a6355
Cypress dashboard.
Tags:
@tag.Sanity, @tag.Widget
Spec:
Fri, 04 Oct 2024 14:40:15 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?