Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replaced some dummy APIs #36655

Open
wants to merge 2 commits into
base: release
Choose a base branch
from
+2 −2
Open

test: replaced some dummy APIs #36655

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84c6538
test: replaced some dummy APIs
Oct 2, 2024
205958c
Update DataManager.ts
NandanAnantharamu Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/client/cypress/support/Objects/DataManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,14 @@ export class DataManager {
mockDatabaseUsername: "fakeapi",
mockDatabasePassword: "LimitedAccess123#",
readonly: "readonly",
authenticatedApiUrl: "https://fakeapi.com",
authenticatedApiUrl: "http://host.docker.internal:5001",

GraphqlApiUrl_TED: "http://host.docker.internal:4200/graphql",

twilio_username: "random-username",
twilio_password: "random-password",

okta_username: "[email protected]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Let's examine the new okta_username property, class.

I notice we've added a new property for Okta authentication. This is an interesting addition to our configuration. However, I have a few questions for you to ponder:

  1. Why might using the same email for both Production and Staging environments be problematic?
  2. Can anyone explain the potential risks of hardcoding credentials in our code?
  3. How could we improve this implementation to align with best security practices?

Remember, in the real world, we always want to protect our application and user data. Let's brainstorm some better approaches to handling authentication credentials.

Would you like me to propose a more secure way to manage these credentials? We could explore environment variables or a secure credential management system.

Also applies to: 212-212

},

Staging: {
Expand Down Expand Up @@ -200,12 +202,14 @@ export class DataManager {
mockDatabaseUsername: "fakeapi",
mockDatabasePassword: "LimitedAccess123#",
readonly: "readonly",
authenticatedApiUrl: "https://fakeapi.com",
authenticatedApiUrl: "http://host.docker.internal:5001",

GraphqlApiUrl_TED: "http://host.docker.internal:4200/graphql",

twilio_username: "random-username",
twilio_password: "random-password",

okta_username: "[email protected]",
},
};

Expand Down
Loading