chore: Run NGINX with readonly root FS support #27453

sharat87 · 2023-09-19T13:09:10Z

Part of supporting readonly root filesystem, gets NGINX to start without doing any writes to the filesystem, except for in /tmp.

ghost · 2023-09-19T13:10:41Z

👇 Click on the image for a new way to code review

Legend

sharat87 · 2023-09-19T13:27:10Z

/ok-to-test

github-actions · 2023-09-19T13:27:51Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6236191677.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 27453.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=27453&runId=6236191677_1

github-actions · 2023-09-19T14:50:13Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6236191677.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/ClientSide/BugTests/AbortAction_Spec.ts
cypress/e2e/ClientSide/ExplorerTests/Admin_settings_2_spec.js
cypress/e2e/Regression/ClientSide/Editor/HelpButton_spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2023-09-19T15:24:57Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6236191677.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/HelpButton_spec.ts

To know the list of identified flaky tests - Refer here

sharat87 · 2023-09-20T00:47:20Z

/ok-to-test

github-actions · 2023-09-20T00:47:44Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6242538023.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 27453.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=27453&runId=6242538023_1

sharat87 · 2023-09-20T01:38:18Z

/build-deploy-preview skip-tests=true

github-actions · 2023-09-20T01:38:43Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6242910831.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 27453.
recreate: .

github-actions · 2023-09-20T01:53:07Z

Deploy-Preview-URL: https://ce-27453.dp.appsmith.com

github-actions · 2023-09-20T02:10:58Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6242538023.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Git/GitSync/RepoLimitExceededErrorModal_spec.js
cypress/e2e/Regression/ClientSide/ThemingTests/Basic_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2023-09-20T02:37:31Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6242538023.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

pratapaprasanna · 2023-09-22T05:58:27Z

DP is failing to start RTS here.

pratapaprasanna

RTS fails to start in dp

pratapaprasanna

│ editor stderr | + popd                                                                                                                                                                                           │
│ editor stderr |                                                                                                                                                                                                  │
│ editor stdout | /opt/appsmith                                                                                                                                                                                    │
│ editor stdout |                                                                                                                                                                                                  │
│ editor stderr | + exec nginx -g 'daemon off;error_log stderr info;'                                                                                                                                              │
│ editor stderr |                                                                                                                                                                                                  │
│ editor stderr | 2023/09/22 08:15:05 [notice] 1502#1502: using the "epoll" event method                                                                                                                           │
│ editor stderr |                                                                                                                                                                                                  │
│ editor stderr | 2023/09/22 08:15:05 [notice] 1502#1502: nginx/1.18.0 (Ubuntu)                                                                                                                                    │
│ editor stderr | 2023/09/22 08:15:05 [notice] 1502#1502: OS: Linux 5.10.186-179.751.amzn2.x86_64                                                                                                                  │
│ editor stderr | 2023/09/22 08:15:05 [notice] 1502#1502: getrlimit(RLIMIT_NOFILE): 1048576:1048576                                                                                                                │
│ editor stderr |                                                                                                                                                                                                  │
│ editor stderr | 2023/09/22 08:15:05 [notice] 1502#1502: start worker processes                                                                                                                                   │
│ editor stderr |                                                                                                                                                                                                  │
│ editor stderr | 2023/09/22 08:15:05 [notice] 1502#1502: start worker process 1531                                                                                                                                │
│ editor stderr |                                                                                                                                                                                                  │
│ editor stderr | 2023/09/22 08:15:05 [notice] 1502#1502: start worker process 1532                                                                                                                                │
│ editor stderr |                                                                                                                                                                                                  │
│ editor stderr | 2023/09/22 08:15:05 [notice] 1502#1502: start worker process 1533                                                                                                                                │
│ editor stderr |                                                                                                                                                                                                  │
│ editor stderr | 2023/09/22 08:15:05 [notice] 1502#1502: start worker process 1534                                                                                                                                │
│ editor stderr |                                                                                                                                                                                                  │
│ editor stderr | 2023/09/22 08:15:05 [notice] 1502#1502: start worker process 1535                                                                                                                                │
│ editor stderr |                                                                                                                                                                                                  │
│ editor stderr | 2023/09/22 08:15:05 [notice] 1502#1502: start worker process 1536                                                                                                                                │
│ editor stderr |                                                                                                                                                                                                  │
│ editor stderr | 2023/09/22 08:15:05 [notice] 1502#1502: start worker process 1537                                                                                                                                │
│ editor stderr |                                                                                                                                                                                                  │
│ editor stderr | 2023/09/22 08:15:05 [notice] 1502#1502: start worker process 1538                                                                                                                                │
│ editor stderr |                                                                                                                                                                                                  │
│ backend stdout | Waiting for RTS to start ...

sharat87 · 2023-09-25T04:33:07Z

@pratapaprasanna, can you share full logs please? I don't see anything wrong the logs snippet above? Can you elaborate on what I'm missing please? 🤔

sharat87 · 2023-09-25T06:12:39Z

/build-deploy-preview skip-tests=true

github-actions · 2023-09-25T06:13:04Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6295583530.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 27453.
recreate: .

sharat87 · 2023-09-25T06:33:26Z

Building DP failed with this:

Deploy appsmith helm chart
Flag --recreate-pods has been deprecated, functionality will no longer be updated. Consult the documentation for other methods to recreate pods
Error: UPGRADE FAILED: cannot patch "ce27453-appsmith" with kind Service: Service "ce27453-appsmith" is invalid: spec.ports[1].name: Duplicate value: "appsmith"
Error: Process completed with exit code 1.

sharat87 · 2023-09-25T08:08:52Z

/build-deploy-preview skip-tests=true recreate=true

github-actions · 2023-09-25T08:09:16Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6296623280.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 27453.
recreate: true.

github-actions · 2023-09-25T08:24:38Z

Deploy-Preview-URL: https://ce-27453.dp.appsmith.com

Part of supporting readonly root filesystem, gets NGINX to start without doing any writes to the filesystem, except for in `/tmp`.

fix: clear postgres core dumps (#27152)

99d87bb

github-actions bot added the Bug Something isn't working label Sep 19, 2023

fix some paths

1294bfa

sharat87 changed the title ~~fix: clear postgres core dumps (#27152)~~ chore: Run NGINX with readonly root FS support Sep 19, 2023

github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog and removed Bug Something isn't working labels Sep 19, 2023

Use top-level await

b09787f

WIP: fix root path for nginx

6299950

sharat87 marked this pull request as draft September 19, 2023 15:28

sharat87 added 3 commits September 20, 2023 05:47

chore: merge release branch

986eb11

Fix incorrect NGINX root

6025f96

Add server_tokens and gzip to loading page as well

342a797

sharat87 requested review from pratapaprasanna and sum35h September 20, 2023 04:58

sharat87 marked this pull request as ready for review September 20, 2023 05:06

Undo removing existing includes, just in case

60a5fe8

pratapaprasanna reviewed Sep 22, 2023

View reviewed changes

sharat87 added 2 commits September 22, 2023 12:02

Merge remote-tracking branch 'origin/release' into chore/nginx-rofs

89c6061

Fix syntax error in prepare script

fffb1b0

sharat87 requested a review from pratapaprasanna September 22, 2023 07:20

pratapaprasanna reviewed Sep 22, 2023

View reviewed changes

pratapaprasanna previously approved these changes Sep 25, 2023

View reviewed changes

Minor refactor

3a0be78

sharat87 dismissed pratapaprasanna’s stale review via 3a0be78 September 27, 2023 08:07

sharat87 merged commit 2f5405d into release Sep 27, 2023
13 of 15 checks passed

sharat87 deleted the chore/nginx-rofs branch September 27, 2023 08:08

rajatagrawal pushed a commit that referenced this pull request Oct 3, 2023

chore: Run NGINX with readonly root FS support (#27453)

27bcc17

Part of supporting readonly root filesystem, gets NGINX to start without doing any writes to the filesystem, except for in `/tmp`.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Run NGINX with readonly root FS support #27453

chore: Run NGINX with readonly root FS support #27453

sharat87 commented Sep 19, 2023

ghost commented Sep 19, 2023 •

edited by ghost

Loading

Legend

sharat87 commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

sharat87 commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

sharat87 commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

pratapaprasanna commented Sep 22, 2023 •

edited

Loading

pratapaprasanna left a comment

pratapaprasanna left a comment

sharat87 commented Sep 25, 2023

sharat87 commented Sep 25, 2023

github-actions bot commented Sep 25, 2023

sharat87 commented Sep 25, 2023

sharat87 commented Sep 25, 2023

github-actions bot commented Sep 25, 2023

github-actions bot commented Sep 25, 2023

chore: Run NGINX with readonly root FS support #27453

chore: Run NGINX with readonly root FS support #27453

Conversation

sharat87 commented Sep 19, 2023

ghost commented Sep 19, 2023 • edited by ghost Loading

Legend

sharat87 commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

sharat87 commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

sharat87 commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023

pratapaprasanna commented Sep 22, 2023 • edited Loading

pratapaprasanna left a comment

Choose a reason for hiding this comment

pratapaprasanna left a comment

Choose a reason for hiding this comment

sharat87 commented Sep 25, 2023

sharat87 commented Sep 25, 2023

github-actions bot commented Sep 25, 2023

sharat87 commented Sep 25, 2023

sharat87 commented Sep 25, 2023

github-actions bot commented Sep 25, 2023

github-actions bot commented Sep 25, 2023

ghost commented Sep 19, 2023 •

edited by ghost

Loading

pratapaprasanna commented Sep 22, 2023 •

edited

Loading