fix: incorporate small fixes from latest project setup #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR! sphinx-spelling does work, but requires enchant to be installed, as per error message. The latter is not a python dependency and must be installed separately by the user. The spelling thing is anyway optional, the user can delete it. I'm no longer entirely sure about the move to mkdocs, now the template makes heavy use of jupyter-book for rendering the docs nicely. Note that we have an internal template based on mkdocs |
MischaPanch
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some small fixes that have been noticed while setting up a project with pymetrius.
Besides these, I also noticed that sphinx-spelling does not work any longer, because
ImportError: The 'enchant' C library was not found and maybe needs to be installed(See: pyenchant/pyenchant#316). I saw that there is an open issue regarding sphinx -> mkdocs so I did not incorporate this already.