ContainerRegistry: Tolerate missing Location header in the manifest PUT response
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
added
semver/minor
euanh
force-pushed
the
tolerate-missing-manifest-location-header
branch
from
47d4f7f
to
e342043
Compare
…st upload response
euanh
force-pushed
the
tolerate-missing-manifest-location-header
branch
from
e342043
to
3cc5555
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
According to distribution spec, the manifest
PUTresponse MUST contain a Location header providing a URL from which the saved manifest can be downloaded. The same requirement applies to blobPUTs. However some registries return URLs which cannot be fetched, and ECR does not set this header at all.The location header is not currently of critical important. If the header is not present, we can create a suitable value based on the spec for manifest downloads.
Modifications
Generate a suitable manifest location URL when the registry does not provide one.
Result
Uploads to ECR will no longer fail because of the missing
Locationheader in the manifestPUTresponse.Test Plan
Automated tests continue to pass; manually tested with ECR.