ContainerRegistry: Pass through the manifest's mediaType, if set #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
added
semver/minor
euanh
force-pushed
the
manifest-mediatype-passthrough
branch
from
062465a
to
d5be4ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the manifest blob's
mediaTypeis set, the distribution spec requires that the HTTPContent-Typeused to upload the manifest should match it.Modifications
In
putManifest, use the blob'smediaTypeif it is set; otherwise default tomanifest.v1.Result
If a manifest uses a different media type, it will be passed through to the registry. This might happen when copying a base image, which could have been created using the older manifest type.
Test Plan
Automated tests continue to pass. Also tested manually with different registries.