Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 1186 #228

Merged
merged 8 commits into from
May 26, 2017
Merged

Conversation

royshouvik
Copy link

@royshouvik royshouvik commented May 9, 2017

This pull request fixes most of the issues mentioned in bug 1186. The number of winners is less wrong now, but would need update on the V3 API to be absolutely correct. Fixes appirio-tech/topcoder-app#1186

@tladendo
Copy link

@royshouvik The code to get the real user avatar that you added doesn't seem to work for me. All profiles are showing the placeholder. Is it working for you?

@royshouvik
Copy link
Author

@tladendo I tested this against the PROD backend and it was working fine for me. I am guessing that we don't have profile images for most of users in dev. Can you please try running against the prod backend and check if it still doesn't work for you?

@tladendo
Copy link

@royshouvik can you point the "results" link to the results page within challenge details?

@royshouvik
Copy link
Author

@tladendo updated link to results page within challenge details

@tladendo
Copy link

@royshouvik on this one too: the past challenges page is coming up blank for me. any idea why?

@tladendo tladendo merged commit d879c2f into appirio-tech:tom-styling-fixes May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants