This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Update dependency eslint to v4 (master) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![appcues-wss[bot]](https://avatars.githubusercontent.com/u/5355844?s=60&v=4){kind=small}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^2.0.0->^4.0.0By merging this PR, the below vulnerabilities will be automatically resolved:
Release Notes
eslint/eslint (eslint)
v4.18.2Compare Source
6b71fd0Fix: [email protected], because 4.0.3 needs "ajv": "^6.0.1" (#10022) (Mathieu Seiler)3c697deChore: fix incorrect comment about linter.verify return value (#10030) (Teddy Katz)9df8653Chore: refactor parser-loading out of linter.verify (#10028) (Teddy Katz)f6901d0Fix: remove catastrophic backtracking vulnerability (fixes #10002) (#10019) (Jamie Davis)e4f52ceChore: Simplify dataflow in linter.verify (#10020) (Teddy Katz)33177cdChore: make library files non-executable (#10021) (Teddy Katz)558ccbaChore: refactor directive comment processing (#10007) (Teddy Katz)18e15d9Chore: avoid useless catch clauses that just rethrow errors (#10010) (Teddy Katz)a1c3759Chore: refactor populating configs with defaults in linter (#10006) (Teddy Katz)aea07dcFix: Make max-len ignoreStrings ignore JSXText (fixes #9954) (#9985) (Rachael Sim)v4.18.1Compare Source
f417506Fix: ensure no-await-in-loop reports the correct node (fixes #9992) (#9993) (Teddy Katz)3e99363Docs: Fixed typo in key-spacing rule doc (#9987) (Jaid)7c2cd70Docs: deprecate experimentalObjectRestSpread (#9986) (Toru Nagashima)v4.18.0Compare Source
70f22f3Chore: Apply memoization to config creation within glob utils (#9944) (Kenton Jacobsen)0e4ae22Update: fix indent bug with binary operators/ignoredNodes (fixes #9882) (#9951) (Teddy Katz)47ac478Update: add named imports and exports for object-curly-newline (#9876) (Nicholas Chua)e8efdd0Fix: support Rest/Spread Properties (fixes #9885) (#9943) (Toru Nagashima)f012b8cFix: support Async iteration (fixes #9891) (#9957) (Toru Nagashima)74fa253Docs: Clarify no-mixed-operators options (fixes #9962) (#9964) (Ivan Hayes)426868fDocs: clean up key-spacing docs (fixes #9900) (#9963) (Abid Uzair)4a6f22eUpdate: support eslint-disable-* block comments (fixes #8781) (#9745) (Erin)777283bDocs: Propose fix typo for function (#9965) (John Eismeier)bf3d494Docs: Fix typo in max-len ignorePattern example. (#9956) (Tim Martin)d64fbb4Docs: fix typo in prefer-destructuring.md example (#9930) (Vse Mozhet Byt)f8d343fChore: Fix default issue template (#9946) (Kai Cataldo)v4.17.0Compare Source
1da1adaUpdate: Add "multiline" type to padding-line-between-statements (#8668) (Matthew Bennett)bb213dcChore: Use messageIds in some of the core rules (#9648) (Jed Fox)1aa1970Docs: remove outdated rule naming convention (#9925) (Teddy Katz)3afaff6Docs: Add prefer-destructuring variable reassignment example (#9873) (LePirlouit)d20f6b4Fix: Typo in error message when running npm (#9866) (Maciej Kasprzyk)51ec6a7Docs: Use GitHub Multiple PR/Issue templates (#9911) (Kai Cataldo)dc80487Update: space-unary-ops uses astUtils.canTokensBeAdjacent (fixes #9907) (#9906) (Kevin Partington)084351bDocs: Fix the messageId example (fixes #9889) (#9892) (Jed Fox)9cbb487Docs: Mention theglobalskey in the no-undef docs (#9867) (Dan Dascalescu)v4.16.0Compare Source
e26a25fUpdate: allow continue instead of if wrap in guard-for-in (fixes #7567) (#9796) (Michael Ficarra)af043ebUpdate: Add NewExpression support to comma-style (#9591) (Frazer McLean)4f898c7Build: Fix JSDoc syntax errors (#9813) (Matija Marohnić)13bcf3cFix: Removing curly quotes in no-eq-null report message (#9852) (Kevin Partington)b96fb31Docs: configuration hierarchy for CLIEngine options (fixes #9526) (#9855) (PiIsFour)8ccbddaDocs: Clarify that -c configs merge with.eslintrc.*(fixes #9535) (#9847) (Kevin Partington)978574fDocs: Fix examples for no-useless-escape (#9853) (Toru Kobayashi)cd5681dChore: Deactivate consistent-docs-url in internal rules folder (#9815) (Kevin Partington)2e87dddDocs: Sync messageId examples' style with other examples (#9816) (Kevin Partington)1d61930Update: use doctrine range information in valid-jsdoc (#9831) (Teddy Katz)133336eUpdate: fix indent behavior on template literal arguments (fixes #9061) (#9820) (Teddy Katz)ea1b15dFix: avoid crashing on malformed configuration comments (fixes #9373) (#9819) (Teddy Katz)add1e70Update: fix indent bug on comments in ternary expressions (fixes #9729) (#9818) (Teddy Katz)6a5cd32Fix: prefer-destructuring error with computed properties (fixes #9784) (#9817) (Teddy Katz)601f851Docs: Minor modification to code comments for clarity (#9821) (rgovind92)b9da067Docs: fix misleading info about RuleTester column numbers (#9830) (Teddy Katz)2cf4522Update: Rename and deprecate object-property-newline option (#9570) (Jonathan Pool)acde640Docs: Add ES 2018 to Configuring ESLint (#9829) (Kai Cataldo)ccfce15Docs: Minor tweaks to working with rules page (#9824) (Kevin Partington)54b329aDocs: fix substitution of {{ name }} (#9822) (Andres Kalle)v4.15.0Compare Source
6ab04b5New: Add context.report({ messageId }) (fixes #6740) (#9165) (Jed Fox)fc7f404Docs: add url to each of the rules (refs #6582) (#9788) (Patrick McElhaney)fc44da9Docs: fix sort-imports rule block language (#9805) (ferhat elmas)65f0176New: CLIEngine#getRules() (refs #6582) (#9782) (Patrick McElhaney)c64195fUpdate: More detailed assert message for rule-tester (#9769) (Weijia Wang)9fcfabfFix: no-extra-parens false positive (fixes: #9755) (#9795) (Erin)61e5fa0Docs: Add table of contents to Node.js API docs (#9785) (Patrick McElhaney)4c87f42Fix: incorrect error messages of no-unused-vars (fixes #9774) (#9791) (akouryy)bbabf34Update: addignoreCommentsoption toindentrule (fixes #9018) (#9752) (Kevin Partington)db431cbDocs: HTTP -> HTTPS (fixes #9768) (#9768) (Ronald Eddy Jr)cbf0fb9Docs: describe how to feature-detect scopeManager/visitorKeys support (#9764) (Teddy Katz)f7dcb70Docs: Add note about "patch release pending" label to maintainer guide (#9763) (Teddy Katz)v4.14.0Compare Source
be2f57eUpdate: support separate requires in one-var. (fixes #6175) (#9441) (薛定谔的猫)370d614Docs: Fix typos (#9751) (Jed Fox)8196c45Chore: Reorganize CLI options and associated docs (#9758) (Kevin Partington)75c7419Update: Logical-and is counted incomplexityrule (fixes #8535) (#9754) (Kevin Partington)eb4b1e0Docs: reintroduce misspelling invalid-typeofexample (#9753) (Teddy Katz)ae51eb2New: Add allowImplicit option to array-callback-return (fixes #8539) (#9344) (James C. Davis)e9d5dfdDocs: improve no-extra-parens formatting (#9747) (Rich Trott)37d066cChore: Add unit tests for overrides glob matching. (#9744) (Robert Jackson)805a94eChore: Fix typo in CLIEngine test name (#9741) (@scriptdaemon)1c2aafdUpdate: Improve parser integrations (fixes #8392) (#8755) (Toru Nagashima)4ddc131Upgrade: debug@^3.1.0 (#9731) (Kevin Partington)f252c19Docs: Make the lint messagesourceproperty a little more subtle (#9735) (Jed Fox)5a5c23cDocs: fix the link to contributing page (#9727) (Victor Hom)f44ce11Docs: change beginner to good first issue label text (#9726) (Victor Hom)14baa2eChore: improve arrow-body-style error message (refs #5498) (#9718) (Teddy Katz)f819920Docs: fix typos (#9723) (Thomas Broadley)43d4ba8Fix: false positive on rulelines-between-class-members(fixes #9665) (#9680) (sakabar)v4.13.1Compare Source
b72dc83Fix: eol-last allow empty-string to always pass (refs #9534) (#9696) (Kevin Partington)d80aa7cFix: camelcase destructure leading/trailing underscore (fixes #9700) (#9701) (Kevin Partington)d49d9d0Docs: Add missing period to the README (#9702) (Kevin Partington)4564fe0Chore: no-invalid-meta crash if no export assignment (refs #9534) (#9698) (Kevin Partington)v4.13.0Compare Source
256481bUpdate: update handling of destructuring in camelcase (fixes #8511) (#9468) (Erin)d067ae1Docs: Don’t use undocumented array-style configuration for max-len (#9690) (Jed Fox)1ad3091Chore: fix test-suite to work with node master (#9688) (Myles Borins)cdb1488Docs: Adds an example with try/catch. (#9672) (Jaap Taal)v4.12.1Compare Source
1e362a0Revert "Fix: Use XML 1.1 on XML formatters (fixes #9607) (#9608)" (#9667) (Kevin Partington)v4.12.0Compare Source
76dab18Upgrade: doctrine@^2.0.2 (#9656) (Kevin Partington)28c9c8eNew: add a Linter#defineParser function (#9321) (Ives van Hoorne)5619910Update: Add autofix forsort-vars(#9496) (Trevin Hofmann)71eedbfUpdate: addbeforeStatementContinuationCharsto semi (fixes #9521) (#9594) (Toru Nagashima)4118f14New: Adds implicit-arrow-linebreak rule (refs #9510) (#9629) (Sharmila Jesupaul)208fb0fFix: Use XML 1.1 on XML formatters (fixes #9607) (#9608) (Daniel Reigada)6e04f14Upgrade:globalsto 11.0.1 (fixes #9614) (#9632) (Toru Nagashima)e13d439Fix: space-in-parens crash (#9655) (Toru Nagashima)92171ccDocs: Updating migration guide for single-line disable (#9385) (Justin Helmer)f39ffe7Docs: remove extra punctuation from readme (#9640) (Teddy Katz)a015234Fix: prefer-destructuring false positive on "super" (fixes #9625) (#9626) (Kei Ito)0cf081eUpdate: add importNames option to no-restricted-imports (#9506) (Benjamin R Gibson)332c214Docs: Add @platinumazure to TSC (#9618) (Ilya Volodin)v4.11.0Compare Source
d4557a6Docs: disallow use of the comma operator using no-restricted-syntax (#9585) (薛定谔的猫)d602f9eUpgrade: espree v3.5.2 (#9611) (Kai Cataldo)4def876Chore: avoid handling rules instances in config-validator (#9364) (Teddy Katz)fe5ac7eChore: fix incorrect comment in safe-emitter.js (#9605) (Teddy Katz)6672faeDocs: Fixed a typo on lines-between-class-members doc (#9603) (Moinul Hossain)980ecd3Chore: Update copyright and license info (#9599) (薛定谔的猫)cc2c7c9Build: use Node 8 in appveyor (#9595) (薛定谔的猫)2542f04Docs: Add missing options forlines-around-comment(#9589) (Clément Fiorio)b6a7490Build: ensure fuzzer tests get run withnpm test(#9590) (Teddy Katz)1073bc5Build: remove shelljs-nodecli (refs #9533) (#9588) (Teddy Katz)7e3bf6aFix: edge-cases of semi-style (#9560) (Toru Nagashima)e5a37ceFix: object-curly-newline for flow code (#9458) (Tiddo Langerak)9064b9cChore: add equalTokens in ast-utils. (#9500) (薛定谔的猫)b7c5b19Fix: Correct [object Object] output of error.data. (#9561) (Jonathan Pool)51c8cf0Docs: Disambiguate definition of Update tag (#9584) (Jonathan Pool)afc3c75Docs: clarify what eslint-config-eslint is (#9582) (Teddy Katz)aedae9dDocs: fix spelling in valid-typeof example (#9574) (Maksim Degtyarev)4c5aaf3Docs: Fix typo in no-underscore-dangle rule (#9567) (Fabien Lucas)3623600Chore: upgrade [email protected] (#9557) (薛定谔的猫)1b606cdChore: Remove an indirect dependency on jsonify (#9444) (Rouven Weßling)4d7d7abUpdate: Resolve npm installed formatters (#5900) (#9464) (Tom Erik Støwer)accc490Fix: Files with no failures get "passing" testcase (#9547) (Samuel Levy)ab0f66dDocs: Add examples to better show rule coverage. (#9548) (Jonathan Pool)88d2303Chore: Add object-property-newline tests to increase coverage. (#9553) (Jonathan Pool)7f37b1cBuild: test Node 9 on Travis (#9556) (Teddy Katz)acccfbdDocs: Minor rephrase inno-invalid-this. (#9542) (Francisc)8f9c0feDocs: improve id-match usage advice (#9544) (Teddy Katz)a9606a3Fix: invalid tests with super (fixes #9539) (#9545) (Teddy Katz)8e1a095Chore: enable a modified version of multiline-comment-style on codebase (#9452) (Teddy Katz)cb60285Chore: remove commented test for HTML formatter (#9532) (Teddy Katz)06b491eDocs: fix duplicate entries in changelog (#9530) (Teddy Katz)2224733Chore: use eslint-plugin-rulesdir instead of --rulesdir for self-linting (#9164) (Teddy Katz)9cf4ebeDocs: add .md to link(for github users) (#9529) (薛定谔的猫)v4.10.0Compare Source
bb6e60aFix: Improve the doc for no-restricted-modules rule (fixes #9437) (#9495) (vibss2397)c529de9Docs: Amend rule document to correct and complete it (refs #6251). (#9498) (Jonathan Pool)f9c6673Chore: Add tests to cover array and object values and leading commas. (#9502) (Jonathan Pool)9169258Chore: removenpm run check-commitscript (#9513) (Teddy Katz)7d390b2Docs: Revise contributor documentation on issue labels. (#9469) (Jonathan Pool)d80b9d0Fix: no-var don't fix globals (fixes #9520) (#9525) (Toru Nagashima)b8aa071Fix: allow linting the empty string from stdin (fixes #9515) (#9517) (Teddy Katz)350a72cChore: regex.test => string.startsWith (#9518) (薛定谔的猫)de0bef4Chore: remove obsolete eslintbot templates (#9512) (Teddy Katz)720b6d5Docs: Update ISSUE_TEMPLATE.md (#9504) (薛定谔的猫)2fa64b7Fix: should not convert non-consecutive line comments to a single blo… (#9475) (薛定谔的猫)9725146Fix: multiline-comment-style fix produces invalid code (fixes #9461). (#9463) (薛定谔的猫)b12cff8Fix: Expected order of jsdoc tags (fixes #9412) (#9451) (Orlando Wenzinger)f054ab5Docs: add.mdto link (for github users) (#9501) (薛定谔的猫)5ed9cfcDocs: Correct violations of “Variable Declarations” in Code Conventions (#9447) (Jonathan Pool)3171097Docs: Clears confusion on usage of global and local plugins.(#9492) (Vasili Sviridov)3204773Chore: enable max-len. (#9414) (薛定谔的猫)0f71fefDocs: Unquote booleans in lines-between-class-members docs (#9497) (Brandon Mills)b3d7532Docs: use consistent terminology & fix link etc. (#9490) (薛定谔的猫)87db8aeDocs: Fix broken links (#9488) (gpiress)51bdb2fDocs: Incorrect link to related rule (#9477) (Gavin King)1a962e8Docs: Add FAQ for when ESLint cannot find plugin (#9467) (Kevin Partington)8768b2dFix: multiline-comment-style autofixer added trailing space (#9454) (Teddy Katz)e830aa1Fix: multiline-comment-style reports block comments followed by code (#9450) (Teddy Katz)b12e5feDocs: Repair broken links and add migration links. (#9473) (Jonathan Pool)eca01edDocs: Add missing info about special status of home-dir config files. (#9472) (Jonathan Pool)eb8cfb1Fix: change err report in constant condition (fixes #9398) (#9436) (Victor Hom)da77eb4Chore: Revise no-config-file test to prevent false failure. (#9443) (Jonathan Pool)47e5f6fDocs: ensure "good commit message" examples actually follow guidelines (#9466) (Teddy Katz)ebb530dUpdate: Don't ignore comments (no-trailing-spaces) (#9416) (Chris van Marle)5012661Build: fixnpm run profilescript (fixes #9397) (#9455) (Teddy Katz)ecac0fdDocs: Remove blockBindings references (#9446) (Jan Pilzer)0b89865Chore: ensure tests for internal rules get run (#9453) (Teddy Katz)052c504Docs: suggest deleting branches after merging PRs (#9449) (Teddy Katz)b31e55aChore: move internal rules out of lib/ (#9448) (Teddy Katz)a7521e3Docs: improve examples for multiline-comment-style (#9440) (Teddy Katz)v4.9.0Compare Source
85388fbFix: Correct error and test messages to fit config search path (#9428) (Jonathan Pool)62a323cFix: Add class options forlines-around-comment(fixes #8564) (#8565) (Ed Lee)8eb4aaeNew: multiline-comment-style rule (fixes #8320) (#9389) (薛定谔的猫)db41408Chore: avoid applying eslint-env comments twice (#9278) (Teddy Katz)febb897Chore: avoid loose equality assertions (#9415) (Teddy Katz)2247efaUpdate: Add FunctionExpression to require-jsdoc (fixes #5867) (#9395) (Kai Cataldo)6791d18Docs: Corrected noun to verb. (#9438) (Jonathan Pool)b02fbb6Update: custom messages for no-restricted-* (refs #8400) (Maja Wichrowska)02732bdDocs: Reorganized to avoid misunderstandings. (#9434) (Jonathan Pool)d9466b8Docs: Correct time forecast for tests. (#9432) (Jonathan Pool)f7ed84fDocs: Add instruction re home-directory config files (refs #7729) (#9426) (Jonathan Pool)30d018bChore: Add Aladdin-ADD & VictorHom to README (#9424) (Kai Cataldo)2d8a303Docs: fix examples for prefer-numeric-literals (#9155) (Lutz Lengemann)d7610f5Docs: Add jquery warning to prefer-destructuring (#9409) (Thomas Grainger)e835dd1Docs: clarify no-mixed-operators (fixes #8051) (Ruxandra Fediuc)51360c8Docs: update block-spacing details (fixes #8743) (#9375) (Victor Hom)6767857Update: fix ignored nodes in indent rule when using tabs (fixes #9392) (#9393) (Robin Houston)37dde77Chore: Refactor SourceCode#getJSDocComment (#9403) (Kai Cataldo)9fedd51Chore: Add missing space in blog post template (#9407) (Kevin Partington)7654c99Docs: add installing prerequisites in readme. (#9401) (薛定谔的猫)786cc73Update: Add "consistent" option to array-bracket-newline (fixes #9136) (#9206) (Ethan Rutherford)e171f6bDocs: add installing prerequisites. (#9394) (薛定谔的猫)74dfc87Docs: update doc for class-methods-use-this (fixes #8910) (#9374) (Victor Hom)b4a9dbfDocs: show console call with no-restricted-syntax (fixes #7806) (#9376) (Victor Hom)8da525fFix: recognise multiline comments as multiline arrays (fixes #9211) (#9369) (Phil Quinn)c581b77Chore: Error => TypeError (#9390) (薛定谔的猫)ee99876New: lines-between-class-members rule (fixes #5949) (#9141) (薛定谔的猫)9d3f5adChore: report unused eslint-disable directives in ESLint codebase (#9371) (Teddy Katz)1167638Update: add allowElseIf option to no-else-return (fixes #9228) (#9229) (Thomas Grainger)4567ab1New: Add the fix-dry-run flag (fixes #9076) (#9073) (Rafał Ruciński)v4.8.0Compare Source
3f2b908New: add option to report unused eslint-disable directives (fixes #9249) (#9250) (Teddy Katz)ff2be59Fix: dot notation rule failing to catch string template (fixes #9350) (#9357) (Phil Quinn)b1372daChore: remove sourceCode property from Linter (refs #9161) (#9363) (Teddy Katz)cef6f8cDocs: remove line about removing rules from semver policy (#9367) (Teddy Katz)06efe87Fix: Add meta element with charset attribute. (#9365) (H1Gdev)458ca67Docs: update architecture page (fixes #9337) (#9345) (Victor Hom)1c6bc67Fix: special EventEmitter keys leak information about other rules (#9328) (Teddy Katz)d593e61Docs: update eslint.org links to use https (#9358) (Teddy Katz)38d0cb2Fix: fix wrong code-path about try-for-in (fixes #8848) (#9348) (Toru Nagashima)434d9e2Fix: Invalid font-size property value issue. (#9341) (H1Gdev)a7668c2Chore: Remove unnecessary slice from logging utility (#9343) (Gyandeep Singh)2ff6fb6Chore: remove unused arguments in codebase (#9340) (Teddy Katz)v4.7.2Compare Source
4f87732Fix: Revert setting node.parent early (fixes #9331) (#9336) (Teddy Katz)v4.7.1Compare Source
08656dbFix: Handle nested disable directive correctly (fixes #9318) (#9322) (Gyandeep Singh)9226495Revert "Chore: rewrite parseListConfig for a small perf gain." (#9325) (薛定谔的猫)v4.7.0Compare Source
787b78bUpgrade: Espree v3.5.1 (fixes #9153) (#9314) (Brandon Mills)1488b51Update: run rules afternode.parentis already set (fixes #9122) (#9283) (Teddy Katz)4431d68Docs: fix wrong config in max-len example. (#9309) (薛定谔的猫)7d24ddeDocs: Fix code snippet to refer to the correct option (#9313) (Ruben Tytgat)12388d4Chore: rewrite parseListConfig for a small perf gain. (#9300) (薛定谔的猫)ce1f084Update: fix MemberExpression handling in no-extra-parens (fixes #9156) (jackyho112)0c720a3Update: allow autofixing when using processors (fixes #7510) (#9090) (Teddy Katz)838df76Chore: upgrade deps. (#9289) (薛定谔的猫)f12def6Update: indent flatTernary option to handlereturn(fixes #9285) (#9296) (Teddy Katz)e220687Fix: remove autofix for var undef inits (fixes #9231) (#9288) (Victor Hom)002e199Docs: fix no-restricted-globals wrong config. (#9305) (薛定谔的猫)fcfe91aDocs: fix wrong config in id-length example. (#9303) (薛定谔的猫)2731f94Update: make newline-per-chained-call fixable (#9149) (João Granado)61f1093Chore: avoid monkeypatching Linter instances in RuleTester (#9276) (Teddy Katz)28929cbChore: remove Linter#reset (refs #9161) (#9268) (Teddy Katz)abc8634Build: re-run browserify when generating site (#9275) (Teddy Katz)7685fedFix: IIFE and arrow functions in no-invalid-this (fixes #9126) (#9258) (Toru Nagashima)2b1eba2Chore: enable eslint-plugin/no-deprecated-context-methods (#9279) (Teddy Katz)981f933Fix: reuse the AST of source code object in verify (#9256) (Toru Nagashima)cd698baDocs: move RuleTester documentation to Node.js API page (#9273) (Teddy Katz)4ae7ad3Docs: fix inaccuracy innpm run perfdescription (#9274) (Teddy Katz)cad45bd](https://togithub.com/eslint/