Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed landscape mode for iphone 11 #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrischang
Copy link

Overview

  • Description: While completing the layout challenge, I notices that the landscape on iphone 11 for the Tipsy-iOS13 was not displaying it correctly. I doubled checked by downloading the original repo again and realized that it was the case. This will work on iphone 11 / 8 since most students are probably taking the suggestion of using iphone 11 or 8.
  • Note: Not really sure if it matters but thought that other students who are taking the course might be wondering, so I decided to send out this PR. Feel free to close this PR if you think it's not necessary.

P.S. Love the course :)

Testing Done

Before the fix
before

After the fix
after

@AhmadDarwich
Copy link

Some students asked about it in the Q&A section of the lecture. It added the PR link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants