Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPSRE-11428 mitigate DT bug #4815

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

fishi0x01
Copy link
Contributor

@fishi0x01 fishi0x01 commented Jan 20, 2025

Dynatrace API does not return milliseconds if they are 000, e.g., 2025-01-18T21:35:03.000Z gets converted to 2025-01-18T21:35:03Z

That leads to the following error in the client API:

ValueError("time data '2025-01-18T21:35:03Z' does not match format '%Y-%m-%dT%H:%M:%S.%fZ'")

We will submit a bug ticket to DT shortly, but until then, we monkey patch a fix to also accept the non-ms format, if we hit a ValueError.

@fishi0x01 fishi0x01 force-pushed the APPSRE-11428_mitigate-dt-bug branch from 897206a to 635d6b9 Compare January 20, 2025 16:11
@fishi0x01 fishi0x01 force-pushed the APPSRE-11428_mitigate-dt-bug branch from 635d6b9 to cc9f971 Compare January 20, 2025 16:11
@fishi0x01 fishi0x01 merged commit 2c66b03 into app-sre:master Jan 20, 2025
1 check passed
@fishi0x01 fishi0x01 deleted the APPSRE-11428_mitigate-dt-bug branch January 20, 2025 16:17
@fishi0x01
Copy link
Contributor Author

Proposing fix here dynatrace-oss/api-client-python#110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants