Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphql-upload to v10.0.0 #3723

Closed
wants to merge 4 commits into from

Conversation

LynchyC
Copy link

@LynchyC LynchyC commented Jan 25, 2020

Update 'singleUpload' tests to reference 'createReadStream' instead of
'stream'

- Update 'singleUpload' tests to reference 'createReadStream' instead of
'stream'
@apollo-cla
Copy link

@LynchyC: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@LynchyC LynchyC requested a review from abernix January 25, 2020 17:32
@LynchyC
Copy link
Author

LynchyC commented Jan 29, 2020

Fixes #3508

@mickeyschwab
Copy link

Does it make sense to bump this to 10 given the latest release?

@LynchyC LynchyC changed the title Update graphql-upload to v9.0.0 Update graphql-upload to v10.0.0 Feb 3, 2020
@artonio
Copy link

artonio commented Feb 21, 2020

I desperately need this feature, will this be merged soon?

@abernix
Copy link
Member

abernix commented Feb 24, 2020

Thanks for opening this PR!

Taking a very quick look at the changelog for graphql-upload, I suspect that landing this upgrade would be a breaking change for the end-user if they haven't made the appropriate changes to their own usage of uploads. If my suspicion is correct, communicating that need would necessitate bumping the major version of Apollo Server accordingly, which the only hesitation in landing this update right now in Apollo Server 2.x.

If someone (@jaydenseric, perhaps?) could dismiss my above suspicion as invalid, then I'd be happy to land this into Apollo Server 2.x. Baring that though, we'd need to wait for a major version bump.

However, since we intend on removing the close coupling between graphql-uploads and Apollo Server in the next major version, as an alternative approach, I'd love to introduce a guide into Apollo Server's documentation which can hopefully demonstrate how to disable the currently baked-in graphql-upload behavior in Apollo Server and show how to use the upstream package directly.

Thoughts?

@abernix abernix closed this Jun 24, 2020
@abernix abernix reopened this Jun 25, 2020
@abernix abernix changed the base branch from master to main June 25, 2020 09:03
@abernix
Copy link
Member

abernix commented Jul 22, 2020

Superseded/duplicated by #4039

@abernix abernix closed this Jul 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants