-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update graphql-upload to v10.0.0 #3723
Conversation
- Update 'singleUpload' tests to reference 'createReadStream' instead of 'stream'
@LynchyC: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Fixes #3508 |
Does it make sense to bump this to 10 given the latest release? |
I desperately need this feature, will this be merged soon? |
Thanks for opening this PR! Taking a very quick look at the changelog for If someone (@jaydenseric, perhaps?) could dismiss my above suspicion as invalid, then I'd be happy to land this into Apollo Server 2.x. Baring that though, we'd need to wait for a major version bump. However, since we intend on removing the close coupling between Thoughts? |
Superseded/duplicated by #4039 |
Update 'singleUpload' tests to reference 'createReadStream' instead of
'stream'