-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add test for router subscription termination via 404 response (#7841)
A user is currently facing an issue where the subscription is not terminating when the router responds to a `next` request with 404. I went to verify this behavior in tests, but this case didn't actually have a test, so I added it. The interesting branch being tested is corresponds to this log line: ``` "SubscriptionManager[1234-cats]: `next` request received 404, terminating subscription" ``` ...which didn't previously exist in any tests before.
- Loading branch information
1 parent
2970cb9
commit 23c40e7
Showing
2 changed files
with
130 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
--- | ||
--- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters