Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update apollo-federation-php with latest schema changes #346

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

dariuszkuc
Copy link
Member

See #166 for details.

Resolves #193

@dariuszkuc dariuszkuc added the php Pull requests that update Php code label Feb 8, 2023
@dariuszkuc
Copy link
Member Author

Federation PHP Compatibility Results

Federation 1 SupportFederation 2 Support
_service
@key (single)
@key (multi)🔲
@key (composite)🔲
repeatable @key🟢
@requires🔲
@provides🟢
federated tracing🔲
@link
@shareable🔲
@tag🔲
@override🔲
@inaccessible🔲

@dariuszkuc dariuszkuc merged commit 98c28f9 into main Feb 8, 2023
@dariuszkuc dariuszkuc deleted the php branch February 8, 2023 21:15
@rvanlaak
Copy link

rvanlaak commented May 30, 2023

Does the above comment on this PR mean that the support as documented on the Apollo support pages is different as expected?

Or, given that the composer.json in this repo's implementations/php folder requires both the webonyx/graphql-php and skillshare/apollo-federation-php, does that mean that solely the skillshare package is actively tested? Because if so, then it might be better to rename that PHP folder to include that library?

@rvanlaak
Copy link

rvanlaak commented May 30, 2023

Would it be an idea to create a follow-up ticket to test the most popular and promising PHP libraries as documented on https://graphql.org/code/#php ?

As example, https://github.com/axtiva/flexible-graphql-php seems to add Federation 2 support on top of webonlyx/graphql-php, but for that library the support does not seem tested yet? (created issue there axtiva/flexible-graphql-php#22)

@dariuszkuc
Copy link
Member Author

Does the above comment on this PR mean that the support as documented on the Apollo support pages is different as expected?

There was a bug (fixed) in how the tests were run (testing old code vs actually changed code) - latest results from CI/CD show the correct results that are the same as published on our docs page.

Or, given that the composer.json in this repo's implementations/php folder requires both the webonyx/graphql-php and skillshare/apollo-federation-php, does that mean that solely the skillshare package is actively tested? Because if so, then it might be better to rename that PHP folder to include that library?

Many GraphQL libraries follow the pattern of "core" library, federation library and high level framework (sometimes they are combined). As documented on our test results page webonyx/graphql-php (reference implementation of GraphQL in PHP) implementation is tested together with skillshare/apollo-federation-php which is a federation library. As per the GraphQL PHP maintainers there are not planning on adding built-in federation support in the core library and they suggest adding the support through additional libraries (i.e skillshare/apollo-federation-php).

Would it be an idea to create a follow-up ticket to test the most popular and promising PHP libraries as documented on https://graphql.org/code/#php ?

You can open a ticket but since integrations are primarily community driven, a PR with example integration would be even better. Check out the subgraph maintainers implementation guide, information about executed tests and contributing guide for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update apollo-federation-php example integration with the latest schema changes
2 participants