Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CLI help comments to reduce memory usage #207

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Conversation

pwittich
Copy link
Contributor

@pwittich pwittich commented Feb 9, 2024

also get rid of some duplication
removed

  • simple_sensor (removed code)
  • watchdog task (commented out by #if 0)

Before:

(base) ➜  apollo_cm_mcu git:(master) make -j8  
  CC    cm_mcu.c
  LD    gcc/cm_mcu.axf 
  SZ    gcc/cm_mcu.axf
   text	   data	    bss	    dec	    hex	filename
  86989	   4628	  45856	 137473	  21901	gcc/cm_mcu.axf

After:

(base) ➜  apollo_cm_mcu git:(cli_help) make -j8 
  CC    cm_mcu.c
  LD    gcc/cm_mcu.axf 
  SZ    gcc/cm_mcu.axf
   text	   data	    bss	    dec	    hex	filename
  85789	   4628	  45856	 136273	  21451	gcc/cm_mcu.axf

text segment reduced by 1200 bytes.

pwittich and others added 3 commits February 8, 2024 21:29
also get rid of some duplication
removed
* simple_sensor
* watchdog task
@pkotamnives pkotamnives self-requested a review February 14, 2024 16:48
Copy link
Contributor

@pkotamnives pkotamnives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you Peter.

projects/cm_mcu/CommandLineTask.c Show resolved Hide resolved
@pwittich pwittich merged commit 0453ea0 into master Feb 15, 2024
6 checks passed
@pwittich pwittich deleted the cli_help branch February 15, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants