17 apd hive file server #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For HEAD, the handler should return None data, which tells webobj only sending headers to client.
Now handler.handle_put() gets a data generator no matter whether the data is chunked or not. Then it handles data in the generator. For the file server, it just writes each chunk of data into a file.
AttributeError: 'Storage' object has no attribute 'handle_put' matches() should always return a handler rather the storage itself.
If the body is empty and its content length is 0, it should not be considered as chunked encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main changes are made on this branch:
Test cases are available in the hivefileserver repo.