Allow writing both html and html_fragment #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check was introduced in e672a0f with no explanation Closes apjanke#60
nabijaczleweli
force-pushed
the
master
branch
from
2184b1f
to
ef088ca
Compare
|
Rebased |
|
This is looking good to me. Let me do a little more testing, and then I'll slide it in for the upcoming release. |
|
Travis CI checks are failing, but it looks unrelated to this PR. I'll try to clean those up and then deal with this. |
|
Merged. This'll go out in 0.10.0. |
|
Oops. Merging this seriously broke the test suite. (I overlooked that because I thought the Travis CI failure was just a Rubocop complaint.) I reverted the change in 4bbb05a and am rescheduling this for 0.11.0 or later. I think I broke the GitHub workflow by reverting the change myself instead of doing a "Revert merge" on GitHub itself. Sorry. Could you re-submit this as another PR if you can figure out a way to have it not break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was expecting this to be a weird bug and not a one-line deletion, hence the issue first.
Closes #60