Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor client modules #70

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Refactor client modules #70

merged 2 commits into from
Nov 13, 2024

Conversation

itssimon
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 92.18241% with 24 lines in your changes missing coverage. Please review.

Project coverage is 93.22%. Comparing base (817385d) to head (274ccd3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apitally/client/server_errors.py 80.00% 18 Missing ⚠️
apitally/client/client_base.py 92.42% 5 Missing ⚠️
apitally/client/consumers.py 98.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   93.04%   93.22%   +0.18%     
==========================================
  Files          13       17       +4     
  Lines        1006     1033      +27     
==========================================
+ Hits          936      963      +27     
  Misses         70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itssimon itssimon merged commit a5f3595 into main Nov 13, 2024
95 of 96 checks passed
@itssimon itssimon deleted the client-refactor branch November 13, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant