fix yaml archives for conformance #1206
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1206 +/- ##
==========================================
- Coverage 71.96% 71.91% -0.06%
==========================================
Files 146 146
Lines 12241 12208 -33
==========================================
- Hits 8809 8779 -30
+ Misses 2749 2747 -2
+ Partials 683 682 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -196,27 +169,6 @@ func applyArtifactPatch(ctx context.Context, client connection.RegistryClient, c | |||
| return nil | |||
| } | |||
|
|
|||
| // populateIdAndKind inserts the "id" and "kind" fields in the supplied json bytes. | |||
| func populateIdAndKind(bytes []byte, kind, id string) ([]byte, error) { | |||
There was a problem hiding this comment.
I think this will break API hub, which currently reads proto-serialized artifacts and expects them to contain "kind" and "id" fields. Since these fields are redundant in Registry YAML, I don't think we should be including them in YAML-serialized artifacts and I expect that API hub will adapt to that when it starts reading those YAML-serialized artifacts.
There was a problem hiding this comment.
That's unfortunate. So I need to add this back for protos?
There was a problem hiding this comment.
Actually, this PR isn't critical until we go all in on yaml...perhaps we should hold it until we correct API Hub.
Fixes #1203