Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SAs for metrics and adapter pods #702

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

jaybooth4
Copy link

@jaybooth4 jaybooth4 commented Sep 19, 2023

Enables workload identity support in Helm

Description

What's changed, or what was fixed?

  • adjust k8s SAs to match required Helm naming scheme

Issues Fixed

  • Fixes E0801 04:25:03.091134 3074510 memcache.go:121] couldn't get resource list for custom.metrics.k8s.io/v1beta1: an error on the server ("Internal Server Error: \"/apis/custom.metrics.k8s.io/v1beta1?timeout=32s\": subjectaccessreviews.authorization.k8s.io is forbidden: User \"system:serviceaccount:apigee:apigee-metrics-sa\" cannot create resource \"subjectaccessreviews\" in API group \"authorization.k8s.io\" at the cluster scope") has prevented the request from succeeding

Housekeeping

(please check all that apply [x], do not edit the text)

  • I have run all the tests locally and they all pass.
  • I have followed the relevant style guide for my changes.

Full Repo Validation Required

(please check all that apply [x], do not edit the text)

  • PR requires full pipeline run (Run for changes only by default).

CC: @apigee-devrel-reviewers

Enables workload identity support in Helm
@jaybooth4 jaybooth4 changed the title Update roles for metrics and adapter pods Update SAs for metrics and adapter pods Sep 19, 2023
@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/hybrid-quickstart pass 1976s
TOTAL PIPELINE pass 1976s

View details in Cloud Build (permission required)

Commit version: a43bad2

@danistrebel danistrebel merged commit cc7246c into apigee:main Sep 20, 2023
6 of 7 checks passed
@danistrebel
Copy link
Collaborator

Thanks for the fix @jaybooth4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants