Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default cache value if cache returns NULL while running test case #449

Merged

Conversation

shishir-intelli
Copy link
Collaborator

In Drupal 10.1, fixed test-case failing, due to error TypeError: Drupal\apigee_edge_teams\Entity\Team::getCacheMaxAge(): Return value must be of type int, null returned.
Set default cache value if cache returns NULL while running test case
Originally issue PR apigee/apigee-edge-drupal#917

@shishir-intelli shishir-intelli added the bug Something isn't working label Sep 26, 2023
@shishir-intelli shishir-intelli added this to the 2.1.2 milestone Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #449 (d7a512b) into 2.x (503a0ec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #449   +/-   ##
=========================================
  Coverage     49.24%   49.24%           
  Complexity     1997     1997           
=========================================
  Files           200      200           
  Lines          7399     7399           
=========================================
  Hits           3644     3644           
  Misses         3755     3755           

Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 495d62d into apigee:2.x Sep 26, 2023
13 of 17 checks passed
@shishir-intelli shishir-intelli deleted the testcase_cache_default_value branch September 26, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants