This repository has been archived by the owner on Aug 3, 2022. It is now read-only.
Fix postgres crash due to array indexing issue #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 9, 2016 07:24
…1 error in the array iteration
|
Dry'd up the code and commented as per internal CR feedback. |
|
Works great. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #17
The problem was the natt iteration variable was being used as an array index, but it can skip outside the bounds of the array, which was ultimately causing a crash inside the protobuf assertion mechanisms that were detecting the memory error.
I've also moved the write outside the release of the memory context, which makes the output plugin consistent with all the other output plugins I can find, though I don't know if ultimately it matters.