Skip to content
This repository has been archived by the owner on Jul 2, 2019. It is now read-only.

Bump json-schema-faker to version 0.5.0-rc15 #168

Closed
wants to merge 1 commit into from
Closed

Bump json-schema-faker to version 0.5.0-rc15 #168

wants to merge 1 commit into from

Conversation

realityking
Copy link
Contributor

No description provided.

pksunkara
pksunkara previously approved these changes Apr 23, 2018
@kylef
Copy link
Member

kylef commented Apr 23, 2018

This one's going to be a bit problematic due to some dependency problems:

Problematic Licenses: 7

[email protected] (Custom: http://jsonselect.org) - license not pre-approved
[email protected] (MIT) - missing full license text
[email protected] (Custom: http://i.imgur.com/goJdO.png) - license not pre-approved, missing full license text
[email protected] (UNKNOWN) - license not pre-approved
[email protected] (Custom: http://github.com/zaach/jison/issues) - license not pre-approved
[email protected] (Custom: http://nodejs.org/) - license not pre-approved, missing full license text
[email protected] (UNKNOWN) - license not pre-approved

I've filed a PR on jison so far but here is the list, I'll update with the status.

@realityking
Copy link
Contributor Author

dchester/jsonpath#94 would help a lot as it removes jison - and its sub-dependencies - from the dependencies.

@kylef
Copy link
Member

kylef commented Apr 23, 2018

I believe dchester/jsonpath#94 would resolve all of the licensing problems as it seems all of the problematic dependencies are introduced via jison. Looks like a much better solution.

Copy link
Member

@kylef kylef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to resolve all of the dependency licensing problems before we're able to update this dependency.

@honzajavorek
Copy link
Contributor

Mind there could be some false negatives in our license checking tool. Last time I recall inspecting colors and the current version has a license text IIRC, it just wasn't detected. It's a mess sometimes and needs manual digging and improving of the tool 😕

@realityking realityking deleted the json-schema-faker branch June 5, 2019 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants