Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency eslint-plugin-react-hooks to v5 #69

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 16, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-plugin-react-hooks (source) ^4.6.2 -> ^5.0.0 age adoption passing confidence

Release Notes

facebook/react (eslint-plugin-react-hooks)

v5.0.0

Compare Source

  • New Violations: Component names now need to start with an uppercase letter instead of a non-lowercase letter. This means _Button or _component are no longer valid. (@​kassens) in #​25162

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested review from dcroote and Siegrift October 16, 2024 14:12
Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a major bump, but it's passing for 91% of repos renovate is tracking.

Seems like we need a repo using the react lints here much like we test for breaking changes in universal and jest rules via commons

Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we need a repo using the react lints here much like we test for breaking changes in universal and jest rules via commons

Yeah, although I am not sure if any open sourced repo is using the react plugins (there are a few private ones though). But the 91% passings is quite a number (so I'd be OK with optimistically merging this).

@dcroote dcroote merged commit 8934d17 into main Oct 18, 2024
6 checks passed
@dcroote dcroote deleted the renovate/major-react-monorepo branch October 18, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants