Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicorn & typescript rule updates #64

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Unicorn & typescript rule updates #64

merged 2 commits into from
Oct 11, 2024

Conversation

dcroote
Copy link
Collaborator

@dcroote dcroote commented Oct 10, 2024

Closes #49. Closes #59.

@dcroote dcroote requested a review from Siegrift October 10, 2024 04:57
@dcroote dcroote self-assigned this Oct 10, 2024
@dcroote dcroote mentioned this pull request Oct 10, 2024
Closed
Siegrift
Siegrift approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@dcroote dcroote merged commit 5ffab36 into main Oct 11, 2024
5 checks passed
@dcroote dcroote deleted the unicorn-typescript-rules branch October 11, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siegrift Siegrift Siegrift approved these changes

Assignees

@dcroote dcroote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable unicorn/no-for-loop Add "no-floating-promises" rule
2 participants
@dcroote @Siegrift