Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Actions workflow to check commons for breaking changes #39

Merged
merged 11 commits into from
Aug 28, 2024
Merged

Add Actions workflow to check commons for breaking changes #39

merged 11 commits into from
Aug 28, 2024

Conversation

dcroote
Copy link
Collaborator

@dcroote dcroote commented Aug 27, 2024

Closes #35

@dcroote dcroote self-assigned this Aug 27, 2024
@dcroote dcroote marked this pull request as ready for review August 28, 2024 05:02
@dcroote dcroote requested a review from Siegrift August 28, 2024 05:02
@dcroote
Copy link
Collaborator Author

dcroote commented Aug 28, 2024

I've tested by encountering CI failure in e1993df before fixing the functional/no-promise-reject issue in #40

Siegrift
Siegrift approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

.github/workflows/check-against-commons.yml Outdated Show resolved Hide resolved
@dcroote dcroote merged commit 568c7ed into main Aug 28, 2024
3 checks passed
@dcroote dcroote deleted the dcroote/issue35 branch August 28, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siegrift Siegrift Siegrift approved these changes

Assignees

@dcroote dcroote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use another api3 repo to test package bumps in CI
2 participants
@dcroote @Siegrift