Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update non-major-dependencies #34

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 12, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@typescript-eslint/eslint-plugin (source) ^8.0.0 -> ^8.2.0 age adoption passing confidence
@typescript-eslint/parser (source) ^8.0.0 -> ^8.2.0 age adoption passing confidence
eslint-config-next (source) ^14.2.5 -> ^14.2.6 age adoption passing confidence
eslint-plugin-cypress ^3.4.0 -> ^3.5.0 age adoption passing confidence
eslint-plugin-jest ^28.6.0 -> ^28.8.0 age adoption passing confidence
eslint-plugin-no-only-tests (source) ^3.1.0 -> ^3.3.0 age adoption passing confidence
eslint-plugin-promise ^7.0.0 -> ^7.1.0 age adoption passing confidence

Release Notes

typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)

v8.2.0

Compare Source

🚀 Features
  • eslint-plugin: add suggestion to require-await to remove async keyword
🩹 Fixes
  • eslint-plugin: [use-unknown-in-catch-callback-variable] flag second argument of .then

  • eslint-plugin: [no-unnecessary-type-assertion] conflict with TS for variables used before assignment

  • eslint-plugin: delete [] in message if ReadOnly<string[]> is detected

  • eslint-plugin: [no-redundant-type-constituents] differentiate a types-error any from a true any

  • eslint-plugin: [no-unnecessary-type-parameters] check mapped constraint types if necessary

  • eslint-plugin: [no-unsafe-enum-comparison] add logic to see through intersections

❤️ Thank You
  • Abraham Guo
  • Dave
  • Jake Bailey
  • James
  • Josh Goldberg ✨
  • liuxingbaoyu
  • Yukihiro Hasegawa
  • Yutong Zhu

You can read about our versioning strategy and releases on our website.

v8.1.0

Compare Source

🚀 Features
  • eslint-plugin: [no-floating-promises] enable "add await" suggestion if ignoreVoid is true

  • typescript-estree: restrict variable declarator definite/init combinations

  • eslint-plugin: [no-unsafe-return] check promise any

  • eslint-plugin: [no-misused-promises] check subtype methods against heritage type methods

🩹 Fixes
  • eslint-plugin: [no-unsafe-enum-comparison] typo in test

  • eslint-plugin: [no-unnecessary-type-parameters] skip checking function bodies for AST references

  • eslint-plugin: [member-ordering] get accessor member name & take into account abstract and decorator

  • eslint-plugin: [prefer-optional-chain] wrong parenthesis fix output

  • eslint-plugin: [no-unnecessary-type-parameters] clarify message

❤️ Thank You
  • Aly Thobani
  • Brad Zacher
  • James
  • Josh Goldberg ✨
  • Joshua Chen
  • Olivier Zalmanski
  • YeonJuan
  • Yukihiro Hasegawa

You can read about our versioning strategy and releases on our website.

typescript-eslint/typescript-eslint (@​typescript-eslint/parser)

v8.2.0

Compare Source

This was a version bump only for parser to align it with other projects, there were no code changes.

You can read about our versioning strategy and releases on our website.

v8.1.0

Compare Source

This was a version bump only for parser to align it with other projects, there were no code changes.

You can read about our versioning strategy and releases on our website.

vercel/next.js (eslint-config-next)

v14.2.6

Compare Source

cypress-io/eslint-plugin-cypress (eslint-plugin-cypress)

v3.5.0

Compare Source

Features
jest-community/eslint-plugin-jest (eslint-plugin-jest)

v28.8.0

Compare Source

Features
  • import formatting rules from eslint-plugin-jest-formatting (#​1563) (74078ee)

v28.7.0

Compare Source

Features
  • allow [@typescript-eslint](https://togithub.com/typescript-eslint) v8 (#​1636) (fb43171)
levibuzolic/eslint-plugin-no-only-tests (eslint-plugin-no-only-tests)

v3.3.0

Compare Source

What's Changed

Full Changelog: levibuzolic/eslint-plugin-no-only-tests@v3.2.0...v3.3.0

v3.2.0

Compare Source

What's Changed

Development Changes

New Contributors

Full Changelog: levibuzolic/eslint-plugin-no-only-tests@v3.1.0...v3.2.0

eslint-community/eslint-plugin-promise (eslint-plugin-promise)

v7.1.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested review from dcroote and Siegrift August 12, 2024 00:54
Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A challenge with version bumps like here is that this package doesn't implement much (or any) typescript, react, jest, etc. that might be affected. Hence, we wouldn't catch new rules or changes that would be annoying to our existing repos until the version is released.

Brainstorming, but what if we set up a CI workflow where we run pnpm pack on this repo to create an installable package, install the package in a clone of one or more other API3 repos, then run eslint. This will then fail if there are breaking changes / rules. WDYT @Siegrift ?

@Siegrift
Copy link
Collaborator

Siegrift commented Aug 12, 2024

Brainstorming, but what if we set up a CI workflow where we run pnpm pack on this repo to create an installable package, install the package in a clone of one or more other API3 repos, then run eslint. This will then fail if there are breaking changes / rules. WDYT @Siegrift ?

Yeah, that sounds good. Feel free to create a ticket for it. That said, I'd rather prioritise automating releases of Airseeker and Signed API.

As a note, this already happened in https://github.com/api3dao/airseeker/actions/runs/10351352825/job/28649687569?pr=367 with a few stylistical jest rules (I think we should disable those).

@Siegrift Siegrift removed their request for review August 12, 2024 11:48
@renovate renovate bot force-pushed the renovate/non-major-dependencies branch from 2f94dc2 to e81c9ce Compare August 12, 2024 19:44
@renovate renovate bot force-pushed the renovate/non-major-dependencies branch 4 times, most recently from edcfc43 to 4abc707 Compare August 20, 2024 13:50
@renovate renovate bot force-pushed the renovate/non-major-dependencies branch 2 times, most recently from 9d3c21a to 20b87b3 Compare August 27, 2024 01:04
@renovate renovate bot force-pushed the renovate/non-major-dependencies branch from 20b87b3 to f328fc2 Compare August 28, 2024 14:53
Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could either disable the new jest/padding-around rules or have to use --fix when incorporating the next release. I'd lean towards the former because it seems like a lot of unnecessary whitespace.

(Also glad to have the does-this-break-commons CI now)

@Siegrift
Copy link
Collaborator

What about disabling https://github.com/dangreenisrael/eslint-plugin-jest-formatting/blob/master/docs/rules/padding-around-expect-groups.md and leaving the others?

I find the others quite reasonable and we're following that convention anyway.

Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM after we fix the CI and decide on the new jest rule.

@dcroote
Copy link
Collaborator

dcroote commented Aug 28, 2024

That sounds reasonable, will do 👍

@dcroote dcroote merged commit fa4d837 into main Aug 29, 2024
3 checks passed
@dcroote dcroote deleted the renovate/non-major-dependencies branch August 29, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants