Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor update beacon set mechanism #183

Merged

Conversation

hiletmis
Copy link
Contributor

@hiletmis hiletmis commented Aug 9, 2024

Closes #182

@hiletmis hiletmis linked an issue Aug 9, 2024 that may be closed by this pull request
Copy link
Member

@bbenligiray bbenligiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep the signMessage() flow as documentation. Check if the account is 0x07b589f06bD0A5324c4E2376d66d2F4F25921DE1, use signMessage() if it is, use the hardcoded calldata otherwise.

@hiletmis
Copy link
Contributor Author

@bbenligiray including gas estimation signatures might not be a good idea. Removed it from script and updated the test call data for nodary-rpc-watcher

@hiletmis hiletmis merged commit 22d4adc into main Oct 15, 2024
3 of 4 checks passed
@hiletmis hiletmis deleted the 182-remove-deployer-restriction-from-updatebeaconset-phase branch October 15, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deployer restriction from updateBeaconSet phase
2 participants