fix: Missing interface in Handle doctrine links guide
#6897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: the tests seems to fail because the existing |
| @@ -429,6 +429,7 @@ public function register(): void | |||
| $this->app->bind(OperationMetadataFactoryInterface::class, OperationMetadataFactory::class); | |||
|
|
|||
| $this->app->tag([ | |||
| BooleanFilter::class, | |||
| @@ -29,7 +31,7 @@ | |||
| )] | |||
| #[Get('/company/{companyId}/employees/{id}')] | |||
| #[ORM\Entity] | |||
| class Employee | |||
| class Employee implements LinksHandlerInterface | |||
There was a problem hiding this comment.
A callable is already used here using stateOptions: new Options(handleLinks: [Employee::class, 'handleLinks'])
|
Not need, for more info: api-platform/docs#2121 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the documentation it's written:
I don't know if it's intended but the
Employeeentity does not implement this interface. I saw that the interface namespace was not the same depending on if we're using Doctrine ODM, Doctrine ORM or Eloquent but I think it must be written somewhere. Otherwise developers will not be notified if the interface change over time.