Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cover react-admin undefined meta param #556

Merged
merged 1 commit into from
May 28, 2024
Merged

cover react-admin undefined meta param #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/hydra/dataProvider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ describe('Transform a React Admin request to an Hydra request', () => {
previousData: {
id: '/entrypoint/resource/1',
},
meta: undefined,
});
const url = mockFetchHydra.mock.calls?.[0]?.[0] ?? new URL('https://foo');
expect(url).toBeInstanceOf(URL);
Expand Down
4 changes: 2 additions & 2 deletions src/hydra/dataProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,10 +351,10 @@ function dataProvider(
}
});
let extraInformation: { hasFileField?: boolean } = {};
if ('meta' in params) {
if (typeof params.meta === 'object') {
extraInformation = params.meta;
}
const updateHttpMethod = extraInformation?.hasFileField ? 'POST' : 'PUT';
const updateHttpMethod = extraInformation.hasFileField ? 'POST' : 'PUT';

switch (type) {
case CREATE:
Expand Down