Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show|Create|EditGuesser viewComponent prop #527

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

PawelSuwinski
Copy link
Contributor

@PawelSuwinski PawelSuwinski commented Feb 15, 2024

In Create/EditGuesser form component can be customised by passing down formComponent prop as renamed component prop (to avoid name collision). Guessers use base RA components that also can take component prop for such customisation but it is omitted, so any further customisation needs a lot of code to assembly custom guesser replacement, so for completeness and simplifying any customisation we can pass this other renamed component prop in this way. WDYT?

See:

@PawelSuwinski PawelSuwinski changed the title viewComponent prop Show|CreateEditGuesser viewComponent prop Feb 15, 2024
@PawelSuwinski PawelSuwinski changed the title Show|CreateEditGuesser viewComponent prop Show|Create|EditGuesser viewComponent prop Feb 15, 2024
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dunglas dunglas merged commit b995088 into api-platform:main Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants