-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/identify relaxation options #14
Conversation
…m relaxation table in identify table.
…fluid_incompressible schemes. Used variant option to select the compute routine. Default variant is set to standard. Adapted mus_assign_mrt_ptr to assign mrtPtr according to a variant. Renamed derive_force to derive_force_MRT, a routine used to tract src_force variable. derive_force for non-mrt need to be implemented.
…mrt_generic with variant option
Did you run this through the regression check already? |
Recheck ran successfully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kannan, I only have some minor remarks to fix up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Thanks.
…ocumentation with supported variants for relaxation schemes
@haraldkl could you please approve this pull request. If everything is okay. |
@KannanMasilamani I added my approval with my last comment, however, there are still open unresolved conversations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This MR introduces variant options for relexation in identify table as described in #10
Additionally, the routine names for bgk, mrt and trt for fluid and fluid_incompressible schemes are renamed according to #10