ZOOKEEPER-4750: Align RequestPathMetricsCollector with FinalRequestProcessor and OpCode #2166
+142
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocessor and OpCode Currently, some path aware opcodes were not reported in `FinalRequestProcessor` and some were not handled in `RequestPathMetricsCollector`. This commit aligns them with `ZooDefs.OpCode`.
kezhuw
commented
May 22, 2024
| @@ -140,6 +150,7 @@ static boolean isWriteOp(int requestType) { | |||
| case ZooDefs.OpCode.sync: | |||
| case ZooDefs.OpCode.create: | |||
| case ZooDefs.OpCode.create2: | |||
| case ZooDefs.OpCode.createTTL: | |||
There was a problem hiding this comment.
I added only createTTL here.
addWatchtouches no persistent data but only volatile data.checkitself modifies nothing. If data of the checking path is modified, it will be tracked through another opcode.reconfigis here already.
Besides above, does sync considered as a write opcode ? I try to be conservative to changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some path aware opcodes were not reported in
FinalRequestProcessorand some were not handled in
RequestPathMetricsCollector. This commit alignsthem with
ZooDefs.OpCode.