Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2901]when creating new queues, queue name is used as queue path #997

Closed
wants to merge 1 commit into from

Conversation

hguo25
Copy link

@hguo25 hguo25 commented Nov 19, 2024

What is this PR for?

At the beginning of creating a new queue, 'queue name' is wrongly used as 'queue path' in some actions like logging, emitting events and emitting metrics. This PR change it to use the correct path from the start.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2901

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@hguo25
Copy link
Author

hguo25 commented Nov 20, 2024

Hi @wilfred-s can you please review this one

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending test runs.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@5d3eb36). Learn more about missing BASE report.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #997   +/-   ##
=========================================
  Coverage          ?   81.32%           
=========================================
  Files             ?       97           
  Lines             ?    15592           
  Branches          ?        0           
=========================================
  Hits              ?    12680           
  Misses            ?     2632           
  Partials          ?      280           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants