-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2797] Increase handlers.go test coverage #970
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #970 +/- ##
==========================================
+ Coverage 80.95% 81.05% +0.10%
==========================================
Files 97 97
Lines 12525 12525
==========================================
+ Hits 10139 10152 +13
+ Misses 2116 2103 -13
Partials 270 270 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Will merge after successful run.
I got it! We shouldn't assert statusOK in this function's test because the tested function will not set statusOK in the slope. |
It should other way around, not equal to StatusInternalServerError. Anyways, not a problem. |
What is this PR for?
Increase test coverage and some refactor.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2797
How should this be tested?
Screenshots (if appropriate)
Questions: