Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1983] Add config to statedump #664

Closed
wants to merge 1 commit into from

Conversation

brandboat
Copy link
Member

What is this PR for?

Add SchedulerConfig and extra configs in /ws/v1/fullstatedump

What type of PR is it?

  • - Improvement

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1983

How should this be tested?

covered by unit test

Questions:

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@manirajv06
Copy link
Contributor

@brandboat Now that #652 has gone in, can you rebase and apply changes on top of it?

@brandboat
Copy link
Member Author

@brandboat Now that #652 has gone in, can you rebase and apply changes on top of it?

roger that

@brandboat
Copy link
Member Author

gentle ping @FrankYang0529, @manirajv06 . Already rebased the latest commit and addressed comments. Could you take a look ? Many thanks !

@manirajv06 manirajv06 closed this in ee8a85a Oct 4, 2023
@brandboat brandboat deleted the YUNIKORN-1983 branch October 4, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants