BZ69355: ExactRateLimiter #767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Accurate rate controller. 2. exposeHeaders
remove unused imports
add License Header
make expose headers follows draft-ietf-httpapi-ratelimit-headers spec.
|
@markt-asf @rmaucher wondering if this PR is appropriate? tks. |
markt-asf
requested changes
Nov 4, 2024
| public final int getCurrentBucketPrefix() { | ||
| return (int) (System.currentTimeMillis() >> this.numBits); | ||
| public final int getBucketPrefix(long timestamp) { | ||
| return (int) (timestamp >> this.numBits); |
There was a problem hiding this comment.
Why make this change? It appears to increase code duplication with no obvious benefit.
Comment on lines
226
to
241
|
|
||
| /** | ||
| * Returns the identifier from the servlet request, which used to work as rate limit by. | ||
| * @param request | ||
| * @return identifier | ||
| */ | ||
| protected String getLimitByIdentifier(ServletRequest request) { | ||
| return request.getRemoteAddr(); | ||
| } | ||
|
|
||
| @Override | ||
| public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) | ||
| throws IOException, ServletException { | ||
|
|
||
| String ipAddr = request.getRemoteAddr(); | ||
| int reqCount = rateLimiter.increment(ipAddr); | ||
| String identifier = getLimitByIdentifier(request); | ||
| int reqCount = rateLimiter.increment(identifier); |
There was a problem hiding this comment.
This looks like another, possibly separate, improvement.
Comment on lines
55
to
56
| timebucket.maintenance.error=定期维护时出现错误 | ||
| exactRateLimiter.maintenance.error=定期维护时出现错误 |
There was a problem hiding this comment.
Can you re-use timebucket.maintenance.error here?
| /** | ||
| * An accurate fixed window limiter. | ||
| */ | ||
| public class ExactRateLimiter implements RateLimiter { |
There was a problem hiding this comment.
It looks like there is scope for a common base class for this class and FastRateLimiter
isapir
reviewed
Nov 4, 2024
@markt-asf smaller PRs came, first one is #775 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace #760: redo pr , change src branche from "main" to a dedicated branch "main_BZ69355".
for headers section, compliance with draft spec of "https://datatracker.ietf.org/doc/draft-ietf-httpapi-ratelimit-headers ".
comparing with no-ratelimit / or fast-ratelimiter, ab test of exact-ratelimiter performance shows that no significant throughout decrease (about -2% / -1%).