Fix: evict cached MBean when bean descriptor content changed to ensure ManagedBean#getMBeanInfo result is correct. #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Chenjp
commented
Sep 19, 2024
Chenjp
commented
- ensure evict cache for each modification like returnType, name, desc, addAttribute etc.
- code refactoring.
- testcase added.
…nType etc. 1. Fix force expire cache XxxInfo#setName, setType, setDescription, setReturnType etc. 2. Code refactoring.
|
Why would MBean info change at runtime? The MBeans pretty much all represent Tomcat internals and they don't change structure at runtime. I'm not seeing the use case for this. |
|
In theory this is an upstream issue (commons-modeler), however it is no longer maintained. |
got it. |
|
Unless a valid use case is provided for this change, this PR will be closed without being applied. |
|
No valid use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.