Added support for JDBC 4.3 beginRequest and endRequest methods. #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aooohan
reviewed
Nov 7, 2023
modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/ConnectionBoundariesTest.java
Outdated
Show resolved
Hide resolved
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Outdated
Show resolved
Hide resolved
ahai-code
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDBC 4.3 added the methods beginRequest and endRequest to java.sql.Connection. These methods hint the driver of the beginning and completion of a request (independent unit of work). Connection pooling manager should call these methods on the underlying connection prior to returning a connection to the caller, and when the applications returns the connection back to the connection pool respectively.
This pull request adds support for beginRequest and endRequest methods to the Tomcat JDBC Connection Pool.