Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding exitOnFirstListenerFailure flag in standardcontext to enable to stop at first listener error #400

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmannibucau
Copy link
Contributor

follow up of the list discussion, trying to propose a new flag.

@rmaucher
Copy link
Contributor

Ideally, this should be resolved one way or the other by the specification. Also I noticed there is a failCtxIfServletStartFails attribute already, which can easily be abused without too many problems. This is for load on startup Servlets. Overall I don't think it's a great plan to add flags for everything.

@rmannibucau
Copy link
Contributor Author

rmannibucau commented Jan 13, 2021

@rmaucher agree it would be great if spec can clarifies it (in a way making the flag true OOTB ;)) but merging with the servlet flag is kind of different, listener being used to setup env (or symmetrically cleanup), you can need to go through them even if some fails (for auditing for ex) whereas servlets being the runtime it is often an all or none so guess we should keep both split.

@markt-asf
Copy link
Contributor

Can you expand on why this is an issue? The web application doesn't start either way and - generally - I think I'd prefer to see the scale of the problem (how many errors are there in total) rather than face an unknown number of repetitions of "start app, fails, fix error, repeat".
I don't recall any EG discussion on this topic but 'll look to see if anything happened before my time or if I've forgotten something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants