Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes TINKERPOP-3120 #2894

Open
wants to merge 1 commit into
base: 3.7-dev
Choose a base branch
from

Conversation

unautre
Copy link

@unautre unautre commented Nov 9, 2024

Hello,
This PR fixes TINKERPOP-3120 that I just created.

Session support seems to have been dropped from the main branch, so this is for 3.7-dev only.

Best regards,

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.42%. Comparing base (9b46b67) to head (476c782).
Report is 273 commits behind head on 3.7-dev.

Files with missing lines Patch % Lines
.../server/handler/WebSocketAuthorizationHandler.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             3.7-dev    #2894      +/-   ##
=============================================
+ Coverage      76.14%   76.42%   +0.28%     
- Complexity     13152    13228      +76     
=============================================
  Files           1084     1060      -24     
  Lines          65160    61493    -3667     
  Branches        7285     7336      +51     
=============================================
- Hits           49616    46999    -2617     
+ Misses         12839    11979     -860     
+ Partials        2705     2515     -190     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kenhuuu
Copy link
Contributor

kenhuuu commented Nov 12, 2024

Hi, thanks for contributing and providing a detailed explanation of the problem in the Jira.

Could you add a test to GremlinServerAuthIntegrateTest for this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants