Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pure sasl with hive python 3.11 #24155

Closed
wants to merge 21 commits into from
Closed

Test pure sasl with hive python 3.11 #24155

wants to merge 21 commits into from

Conversation

mdeshmu
Copy link
Contributor

@mdeshmu mdeshmu commented May 21, 2023

SUMMARY

Superset PyHive tests are failing in PY 3.11, due to incompatibility issues with sasl lib. This PR is to check the the fix I raised for PyHive at
dropbox/PyHive#454

Note: This PR is just for testing purpose and will be closed once PyHive PR is merged.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Merging #24155 (4072ff8) into master (38ff5d3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4072ff8 differs from pull request most recent head 73ee7ec. Consider uploading reports for the commit 73ee7ec to get more accurate results

@@           Coverage Diff           @@
##           master   #24155   +/-   ##
=======================================
  Coverage   68.93%   68.93%           
=======================================
  Files        1904     1904           
  Lines       73878    73890   +12     
  Branches     8119     8119           
=======================================
+ Hits        50927    50938   +11     
- Misses      20840    20841    +1     
  Partials     2111     2111           
Flag Coverage Δ
hive 53.95% <55.55%> (+0.01%) ⬆️
mysql 79.25% <100.00%> (+<0.01%) ⬆️
postgres 79.34% <100.00%> (+<0.01%) ⬆️
presto 53.87% <55.55%> (+<0.01%) ⬆️
python 83.33% <100.00%> (+<0.01%) ⬆️
sqlite 77.84% <100.00%> (+<0.01%) ⬆️
unit 54.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/common/chart_data.py 100.00% <100.00%> (ø)
superset/sql_parse.py 96.62% <100.00%> (+0.05%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley
Copy link
Member

@mdeshmu would you mind filling out the PR summary so reviewers can better grok the intention for the change?

@mdeshmu
Copy link
Contributor Author

mdeshmu commented May 22, 2023

@john-bodley sorry for inconvenience. Added the summary.

@mdeshmu mdeshmu closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants