[WIP][SPARK-50323][CONNECT][PYTHON] Add missing schema check for createDataFrame from numpy ndarray on Spark Connect #48887
+55
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinrong-meng
changed the title
|
my concern is that the pandas conversion is out of control, what about introducing a similar check in |
xinrong-meng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add missing schema check for createDataFrame from numpy ndarray on Spark Connect
Why are the changes needed?
Currently, the conversion from ndarray to pa.table doesn’t consider the schema at all (for e.g.).
If we handle the schema separately for ndarray -> Arrow, it will add additional complexity (for e.g.) and may introduce inconsistencies with Pandas DataFrame behavior—where in Spark Classic, the process is ndarray -> pdf -> Arrow.
To maintain consistency and simplicity, we follow this approach in Spark Connect.
Does this PR introduce any user-facing change?
Schema check and verification aligns with Spark Classic now.
How was this patch tested?
Unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.