[SPARK-50329][SQL] fix InSet$toString #48865
Open
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
HyukjinKwon
reviewed
Nov 16, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
Show resolved
Hide resolved
attilapiros
approved these changes
Nov 21, 2024
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerLoggingSuite.scala
Outdated
Show resolved
Hide resolved
|
I am fine with this change but just wanted to make sure - does it affect any end-user usecase? |
It won't affect any successful queries, as queries running successfully either don't have unresolved children for InSet during execution or don't enable loggings calling InSet$toString. Queries failed due to InSet$toString will run successfully after the change. |
HyukjinKwon
reviewed
Nov 22, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
Outdated
Show resolved
Hide resolved
|
cc @cloud-fan |
cloud-fan
reviewed
Nov 22, 2024
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerLoggingSuite.scala
Outdated
Show resolved
Hide resolved
attilapiros
reviewed
Nov 22, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
Outdated
Show resolved
Hide resolved
MaxGekk
reviewed
Nov 22, 2024
| @@ -609,6 +609,9 @@ case class InSet(child: Expression, hset: Set[Any]) extends UnaryExpression with | |||
| require(hset != null, "hset could not be null") | |||
|
|
|||
| override def toString: String = { | |||
| if (!child.resolved) { | |||
| return s"$child INSET " + hset.toSeq.mkString("(", ", ", ")") | |||
There was a problem hiding this comment.
I wonder what we will see if hset elements are arrays like Array[Byte] - just address of the array, for timestamp - some number of microseconds?
There was a problem hiding this comment.
I think so, without data type there is not much we can do.
cloud-fan
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix InSet$toString for unresolved plan node
Why are the changes needed?
InSet$toString should always work even for unresolved node
Does this PR introduce any user-facing change?
No
How was this patch tested?
end to end test by running TPCDS benchmark suite with planChangeLog enabled.
Was this patch authored or co-authored using generative AI tooling?
No