[SPARK-50322][SQL] Fix parameterized identifier in a sub-query #48847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
srielau
approved these changes
Nov 14, 2024
cloud-fan
reviewed
Nov 15, 2024
sql/core/src/test/scala/org/apache/spark/sql/ParametersSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Nov 15, 2024
| @@ -189,7 +189,8 @@ object BindParameters extends ParameterizedQueryProcessor with QueryErrorsBase { | |||
| // We should wait for `CTESubstitution` to resolve CTE before binding parameters, as CTE | |||
| // relations are not children of `UnresolvedWith`. | |||
There was a problem hiding this comment.
I'm thinking of a different approach: shall we explicitly match UnresolvedWith here and bind parameters in the CTE relations? Then we no longer need this hack to delay parameter binding.
There was a problem hiding this comment.
Can we do that in 2 steps: 1. fix the issue, 2. do the proposed refactoring? It seems less risky, so, the first patch could be backported more safely.
cloud-fan
approved these changes
Nov 15, 2024
|
Merging to master. Thank you, @srielau and @cloud-fan for review. |
|
We don't need to backport this fix to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to postpone parameters resolution till
UnresolvedWithCTERelationsis resolved.Why are the changes needed?
To fix the query failure:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running new test:
Was this patch authored or co-authored using generative AI tooling?
No.