[SPARK-45039][SQL] Include full identifier in Storage tab #42759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c6f0987.
…ure/improve_cache_storage_view
|
CC @cloud-fan |
|
The error in the test does not appear to be related to change |
planga82
changed the title
cloud-fan
reviewed
Sep 5, 2023
| spark.sessionState.sqlParser.parseMultipartIdentifier(table) match { | ||
| case Seq(_) if spark.catalog.getTable(table).isTemporary => table | ||
|
|
||
| case CatalogAndIdentifier(cat, ident) => s"${cat.name()}.${ident.toString}" |
There was a problem hiding this comment.
I think we should ask the caller side to pass in a fully qualified table name, instead of relying on the current catalog/namespace here.
There was a problem hiding this comment.
makes sense, I will make the changes, thank you!
|
@cloud-fan I made the changes, what do you think? thanks! |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If you have 2 databases with tables with the same name like: db1.table, db2.table
You cannot differentiate it in the Storage tab
What is proposed is to add the full identifier
With this PR it’s also modified the node name in the sql tab
Why are the changes needed?
Facilitates the interpretation of the Storage tab
Does this PR introduce any user-facing change?
Yes, in the UI
How was this patch tested?
Unit testing and manual tests
Was this patch authored or co-authored using generative AI tooling?
No