[SPARK-44916][DOCS][TESTS] Document Spark Driver Live Log UI #42615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Aug 22, 2023
| assert(DriverLogger(sparkConf.set(DRIVER_LOG_LOCAL_DIR, "file://tmp/")).isEmpty) | ||
| withTempDir { dir => | ||
| assert(DriverLogger(sparkConf.set(DRIVER_LOG_LOCAL_DIR, dir.getCanonicalPath)).isEmpty) | ||
| } |
There was a problem hiding this comment.
I piggy-backed this to clean up the generated log directory properly.
|
Could you review this PR, @viirya ? |
viirya
approved these changes
Aug 22, 2023
|
Thank you, @viirya ! |
|
Merged to master for Apache Spark 4. |
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
### What changes were proposed in this pull request? This PR aims to document `Spark Driver Live Log UI`. In addition, this PR fixed a test case to clean up the test directory properly. ### Why are the changes needed? To help a user to use this feature easily, especially in K8s environment. **1. `Spark Configuration` page**  **2. `Running Spark on Kubernetes` page**  ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#42615 from dongjoon-hyun/SPARK-44916. Lead-authored-by: Dongjoon Hyun <[email protected]> Co-authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
### What changes were proposed in this pull request? This PR aims to document `Spark Driver Live Log UI`. In addition, this PR fixed a test case to clean up the test directory properly. ### Why are the changes needed? To help a user to use this feature easily, especially in K8s environment. **1. `Spark Configuration` page**  **2. `Running Spark on Kubernetes` page**  ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#42615 from dongjoon-hyun/SPARK-44916. Lead-authored-by: Dongjoon Hyun <[email protected]> Co-authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 9b75768) Signed-off-by: Dongjoon Hyun <[email protected]>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
### What changes were proposed in this pull request? This PR aims to document `Spark Driver Live Log UI`. In addition, this PR fixed a test case to clean up the test directory properly. ### Why are the changes needed? To help a user to use this feature easily, especially in K8s environment. **1. `Spark Configuration` page**  **2. `Running Spark on Kubernetes` page**  ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#42615 from dongjoon-hyun/SPARK-44916. Lead-authored-by: Dongjoon Hyun <[email protected]> Co-authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to document
Spark Driver Live Log UI. In addition, this PR fixed a test case to clean up the test directory properly.Why are the changes needed?
To help a user to use this feature easily, especially in K8s environment.
1.
Spark Configurationpage2.
Running Spark on KubernetespageDoes this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.