[SPARK-44549][SQL] Support window functions in correlated scalar subqueries #42383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
jchen5
reviewed
Aug 18, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala
Outdated
Show resolved
Hide resolved
added more tests |
jchen5
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Looks good! CC @allisonwang-db @cloud-fan for review as well
allisonwang-db
approved these changes
Aug 22, 2023
sql/core/src/test/resources/sql-tests/inputs/subquery/exists-subquery/exists-aggregate.sql
Show resolved
Hide resolved
cloud-fan
approved these changes
Aug 23, 2023
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support window functions in correlated scalar subqueries.
Support in IN/EXISTS subqueries will come after we migrate them into DecorrelateInnerQuery framework. In addition, correlation is not yet supported inside the window function itself.
Why are the changes needed?
Supports more subqueries.
Does this PR introduce any user-facing change?
Yes, users can run more subqueries now.
How was this patch tested?
Unit and query tests. The results of query tests were checked against Postgresql.