Skip to content

Commit

Permalink
[SPARK-45077][UI] Upgrade dagre-d3.js from 0.4.3 to 0.6.4
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

This PR upgrades `dagre-d3.js` from 0.4.3 to 0.6.4, a.k.a. changes the dist build by https://github.com/andrewor14/dagre-d3 to https://github.com/yaooqinn/dagre-d3/releases/tag/v0.6.4-patch.

`dagre-d3.js` renders DAG to visualize stages, jobs, and SQL in SVG formats. The customization of `dagre-d3` is necessary for items like:

- Save node and cluster IDs and labels for post-processing later, for example, `setupTooltipForSparkPlanNode`.
- Add cluster label to the right top of cluster, which stays in the middle of the cluster. The label also affects the paddingTop of the cluster then.

The full list of commits can be found at:

- In this Patch: yaooqinn/dagre-d3@v0.6.4...v0.6.4-patch
- Before this Patch: andrewor14/dagre-d3@75c17e6...074b99f

### Why are the changes needed?

0.4.3 is pretty old, it's necessary for future improvement in UI, such as zooming etc

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

Tested with the case bellow and verify the SVG objects on both SQL and stage pages

```
spark-sql (default)> select avg(id) from range(1E10) group by id % 5;
```

![image](https://github.com/apache/spark/assets/8326978/45d82fd4-3e00-4b0f-a697-a5661a3b3be5)

![image](https://github.com/apache/spark/assets/8326978/768e59bc-47d5-4db3-b7d0-d85925a53b06)

### Was this patch authored or co-authored using generative AI tooling?

no

Closes #42815 from yaooqinn/SPARK-45077.

Authored-by: Kent Yao <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
  • Loading branch information
yaooqinn authored and srowen committed Sep 7, 2023
1 parent 0e6e15c commit b8b58e0
Showing 1 changed file with 4,829 additions and 7 deletions.
Loading

0 comments on commit b8b58e0

Please sign in to comment.